Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support leaflet panes (1.0 feature) #45

Open
a1an77 opened this issue Apr 5, 2016 · 5 comments
Open

Support leaflet panes (1.0 feature) #45

a1an77 opened this issue Apr 5, 2016 · 5 comments

Comments

@a1an77
Copy link

a1an77 commented Apr 5, 2016

Hi, in my project I am using leaflet panes http://leafletjs.com/examples/map-panes.html
It turns out that this plugin does not consider them at all, hence the paths get drawn in the custom pane while the text is drawn on the overlay pane. This leads to paths been shown above other features while text gets drawn below them. It would be great if the plugin could check on which pane its path gets drawn and put the text on the same one accordingly.

@a1an77
Copy link
Author

a1an77 commented Apr 14, 2016

I just created a pull request with changes from my repo. I added the 'pane' option explicitly even though getting it from the layer where the path lies would be even better. This does the trick for now anyway.

@a1an77
Copy link
Author

a1an77 commented Jun 30, 2016

Anything preventing this from getting in?

@Azbesciak
Copy link

Don't know how it looks in your case, but I even get errors like:

TypeError: Cannot read property '_container' of undefined
    at NewClass.setText (leaflet.textpath.js:78)
    at NewClass._textRedraw (leaflet.textpath.js:43)
    at NewClass._updatePath (leaflet.textpath.js:36)
    at NewClass._update (leaflet-src.js:8384)
    at NewClass._updatePaths (leaflet-src.js:12042)
    at NewClass.fire (leaflet-src.js:593)
    at NewClass._update (leaflet-src.js:12756)
    at NewClass._onZoomStart (leaflet-src.js:12733)
    at NewClass.fire (leaflet-src.js:593)
    at NewClass._moveStart (leaflet-src.js:4213)

Can this PR be merged?

@jcimoch
Copy link

jcimoch commented Apr 21, 2020

Having the same issue

@jayli3n
Copy link

jayli3n commented Sep 6, 2023

This issue should be addressed in this PR #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants