Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Kirklees completely new website? #2988

Open
3 of 7 tasks
andrewpwade opened this issue Nov 4, 2024 · 2 comments
Open
3 of 7 tasks

[Bug]: Kirklees completely new website? #2988

andrewpwade opened this issue Nov 4, 2024 · 2 comments

Comments

@andrewpwade
Copy link

andrewpwade commented Nov 4, 2024

I Have A Problem With:

A specific source

What's Your Problem

The bin lookup UI (and their implementation) seems completely different now and I can't see a link to a calendar (which is what the current implementation looks for). The UI just now shows the next 2 collection dates, that's all you get.

(I've looked at the network requests too - it only returns 2 by default from the API. The API request is incredibly complex, and I can't see an obvious way to get more than 2 bin dates)

Is it worth trying to support this new data source with just 2 calendar days? I could look in to this if you believe it's worth it

If not, should the source be removed as it seems totally incompatible?

Source (if relevant)

kirklees_gov_uk

Logs

No response

Relevant Configuration

No response

Checklist Source Error

  • Use the example parameters for your source (often available in the documentation) (don't forget to restart Home Assistant after changing the configuration)
  • Checked that the website of your service provider is still working
  • Tested my attributes on the service provider website (if possible)
  • I have tested with the latest version of the integration (master) (for HACS in the 3 dot menu of the integration click on "Redownload" and choose master as version)

Checklist Sensor Error

  • Checked in the Home Assistant Calendar tab if the event names match the types names (if types argument is used)

Required

  • I have searched past (closed AND opened) issues to see if this bug has already been reported, and it hasn't been.
  • I understand that people give their precious time for free, and thus I've done my very best to make this problem as easy as possible to investigate.
@andrewpwade
Copy link
Author

bins

@dt215git
Copy link
Contributor

dt215git commented Nov 5, 2024

Looking at the various json responses, it seems like there are 2 dates returned for grey bins and up to 4 dates for the green bins.

There are a few other UK-based sources using the apibroker/runLookup approach so you may be able to adapt one of those. I think the biggest challenge is working out the minimum amount of info needed in the payloads. It still appears to be utilising the uprn, so it may be a case of working out what else needs to be supplied alongside that bit of info.

The burnley_gov_uk source might be a useful starting point.

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants