Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for missing rf=n in sharded table creation #405

Open
5 tasks
PavelShilin89 opened this issue Dec 3, 2024 · 2 comments
Open
5 tasks
Assignees
Labels
bug Something isn't working

Comments

@PavelShilin89
Copy link

Bug Description:

When the CREATE TABLE command does not include the rf=n (replication factor) parameter, instead of the ERROR 1064 (42000): P03: syntax error, unexpected integer, expecting string near '3' a more informative error message should be returned, explaining that rf=n is required.

Suggested improved error message:

ERROR 1064 (42000): Sharded table requires `rf=n`

Manticore Search Version:

Latest dev version

Operating System Version:

Ubuntu Jammy

Have you tried the latest development version?

Yes

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
@PavelShilin89 PavelShilin89 added the bug Something isn't working label Dec 3, 2024
@donhardman
Copy link
Contributor

Fix implemented in this pull: #426

@donhardman
Copy link
Contributor

@Nick-S-2018 please review

@donhardman donhardman assigned Nick-S-2018 and unassigned donhardman Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants