Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing Swoole's package_max_length #423

Open
1 of 6 tasks
Nick-S-2018 opened this issue Dec 18, 2024 · 2 comments
Open
1 of 6 tasks

Increasing Swoole's package_max_length #423

Nick-S-2018 opened this issue Dec 18, 2024 · 2 comments
Assignees

Comments

@Nick-S-2018
Copy link
Contributor

Proposal:

We may need to increase the default value of package_max_length in Swoole. That would help to accelerate dumps made with Elasticdump, since now we have to limit dump batch size to match this value.

Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
  • OpenAPI YAML updated and issue created to rebuild clients
@Nick-S-2018
Copy link
Contributor Author

@donhardman, pls check if this can be done and if such change doesn't cause any side effects in Buddy,

@donhardman
Copy link
Contributor

Please take a look here #427

I tried to run some benchmarks and the new parameters do not affect it, so if it's enough, feel free to merge. If we need to increase more, let me know.

@donhardman donhardman assigned Nick-S-2018 and unassigned donhardman Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants