Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different error on insert for distributed table or missing table #2785

Closed
6 tasks done
donhardman opened this issue Nov 25, 2024 · 6 comments · Fixed by #2809
Closed
6 tasks done

Different error on insert for distributed table or missing table #2785

donhardman opened this issue Nov 25, 2024 · 6 comments · Fixed by #2809
Assignees
Labels
rel::upcoming Upcoming release

Comments

@donhardman
Copy link
Contributor

donhardman commented Nov 25, 2024

Proposal:

Currently, when a table does not exist or it does not support inserts, we have the following error:

table 'hello2' absent, or does not support INSERT

Unfortunately, we now use Buddy to support auto-schema inserts and distributed inserts, but this makes it impossible to detect which table we're performing inserts on.

Therefore, we should split the error message into two distinct messages:

For missing tables:

table 'test' absent

For distributed tables:

table `test` does not support INSERT

Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
  • OpenAPI YAML updated and issue created to rebuild clients
@sanikolaev
Copy link
Collaborator

This issue blocks manticoresoftware/manticoresearch-buddy#392

@tomatolog
Copy link
Contributor

fixed at b7992be

Now insert into missed table generates error table 'test' absent if the table is not RT or Percolate the error is table test does not support INSERT.

Not sure does this ticket need the test cases and what cases should be covered.

@PavelShilin89
Copy link
Contributor

@donhardman @tomatolog The test is created in this PR - #2809 but at the moment the errors are not as expected.
Current result:
For distributed tables - ERROR 1064 (42000) at line 1: table 'dist_table' absent
For missing tables - no error

@tomatolog
Copy link
Contributor

I will check the case at the test/clt-tests/core/test-errors-insert-for-distributed-missing-table.rec as daemon seems generate wrong error message

@tomatolog
Copy link
Contributor

seems the case that table is distributed is not covered by initial fix and fixed at 1e36108

Need to rerun the #2809 and make sure the error messages look good now or fix the test outputs

@tomatolog tomatolog reopened this Dec 3, 2024
@PavelShilin89 PavelShilin89 linked a pull request Dec 5, 2024 that will close this issue
@PavelShilin89
Copy link
Contributor

PavelShilin89 commented Dec 5, 2024

@sanikolaev Test updated in PR - #2809
Review and approval to merge with a master is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rel::upcoming Upcoming release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants