-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update meow to v9 and devDependencies #86
Conversation
@tristen it looks like tests using Node 10 are failing, which I believe is due to the update to eslint. Do you think it would make sense to update |
@dpdiliberto that seems like a sensible change to me 👍. Maybe we can replace 10 and 12 with more recent 16 and 18 versions. |
Thanks @tristen , I updated the Node versions, and also upgraded the Travis build environment (per https://travis-ci.community/t/the-command-npm-config-set-spin-false-failed-and-exited-with-1-during/12909/7), since I was running into the following build error:
All checks are passing now 👍 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dpdiliberto and @tristen , please help publish a new release to NPM. |
Thanks @tristen . |
Looks upgrading the
|
👋 @leslieli want to put a pull request together that addresses the issue? I'd be happy to review and cut a new release. |
@tristen I am not quite familiar with the project and would like to suggest someone in your team could help on this. If possible, could you provide the estimation - when we can expect the fix release? Thanks. |
Updating dependencies to help resolve #84. Per sindresorhus/meow#204 (comment), I updated meow to v9 rather than to the latest since later versions require ESM.