Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Running tileserver-php via Docker on Windows using a bind mount volume makes filemtime() return 0 #148

Open
jbaranski opened this issue Jan 22, 2020 · 0 comments

Comments

@jbaranski
Copy link

jbaranski commented Jan 22, 2020

If filemtime returns 0, the ETag hash is always the same and therefore every file attempted to serve 304's.

If filemtime is run on any file inside the container that's not part of the host mount volume (like /start.sh) it returns the correct value.

Any thoughts on the best way to resolve this? Here are a couple ideas:

  • Modify your code to check a flag and short circuit the isModified function if set, (HTTP_IF_MODIFIED_SINCE or HTTP_IF_NONE_MATCH could be set to SKIP or EXIT in .htaccess instead of an actual timestamp)
  • If lastModifiedTime in isModified is 0 don't set any headers, skip out and return false

If you have any other ideas I'd like to hear them, I would be happy to put together an MR based on what you want to do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant