Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

works good on ac200max, but please implement more #8

Open
mbay0r opened this issue Dec 11, 2022 · 11 comments
Open

works good on ac200max, but please implement more #8

mbay0r opened this issue Dec 11, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@mbay0r
Copy link

mbay0r commented Dec 11, 2022

it works very well with ac200max, thanks for the great work!

but unfortunately not much is supported yet, maybe you could add the rest of https://github.com/warhammerkid/bluetti_mqtt/blob/main/bluetti_mqtt/core/devices/ac200m.py ?

thanks a lot

@mariolukas mariolukas added the enhancement New feature or request label Dec 12, 2022
@viper4gh
Copy link

Hi,
I used it with an M5Stack Atom Lite and it works good. The Atom has a built-in RGB LED and I added some lines for activating different colors for different connect states like WiFi, MQTT, Bluetooth connected, which helps with the following.
I have sometimes connect issues on WiFi or Bluetooth after multiple resets, but I open a seperate issue for it.

If it is possible I have the same request for adding the rest of the values which are provided by the python script.
Further it would be nice if the ac_power_on and dc_power_on are command datapoints also available as state, because with the command datapoints you don't know the current state at the powerstation.

@AlexBurghardt
Copy link
Contributor

AlexBurghardt commented Jan 20, 2023

I have improved several things. Now I have 20+ values available in iobroker (via mqtt) including the ac/dc states of my AC200M.
Soon you will see it here on github..

@DraycD
Copy link

DraycD commented Jan 21, 2023

I have improved several things. Now I have 20+ values available in iobroker (via mqtt) including the ac/dc states of my AC200M.
Soon you will see it here on github..

Will they also been shown on the EP500P ?

@mariolukas
Copy link
Owner

Will they also been shown on the EP500P ?

When the address range of the EP500P is the same as for the already supported devices it should work. Otherwise we need to reverse engineer on a EP500P.

@mariolukas
Copy link
Owner

I have improved several things. Now I have 20+ values available in iobroker (via mqtt) including the ac/dc states of my AC200M.
Soon you will see it here on github..

I would appreciate a PR.

@AlexBurghardt
Copy link
Contributor

@mariolukas: PR is done, please check.

Since this is my very first contribution, I will also have to learn how Git/Github works in detail.
Today I synchronized my fork with your main and that led to a second commit in my PR. Don't know why. The first commit contains my improved code.

@mariolukas
Copy link
Owner

mariolukas commented Jan 30, 2023

Yes, thank you for your commitment. I appreciate it a lot.

But it will take me some time to merge this into actual code.

I will also have to learn how Git/Github works in detail.

One suggestion for your next PR. Just do your changes on the current code in the code folder and do a PR. That makes merging a lot easier for me.

I need to compare each single file of your PR #33 in the main folder with the current code base in my source folder and cherry pick the changes you've made.

@AlexBurghardt
Copy link
Contributor

Yes, no diffs are displayed. I noticed it and I try to do it the way it should be done next time.
Feel free to ask me about my changes. Also a Webex live review would be possible to make it easier for you to understand the changes.

@AlexBurghardt
Copy link
Contributor

@mariolukas: Would it be better to close the pull request, updating my repository to the current status/code and committing my changes to it? Then I could make specific PRs with differences being displayed. But that would take a few days more...

@mariolukas
Copy link
Owner

Yes i think that would be a better way to merge the PR. Please leave a comment to the PR and describe what you changed ( no details needed, only what you fixed or which new features are added ...). Thanks!

@cybercreature
Copy link

it works very well with ac200max, thanks for the great work!

but unfortunately not much is supported yet, maybe you could add the rest of https://github.com/warhammerkid/bluetti_mqtt/blob/main/bluetti_mqtt/core/devices/ac200m.py ?

thanks a lot

Hello,

how did you manage the connection to the Bluetti. I cannot connect to the AC200MAX.

Did you have to make any changes to the code?

thanks

@bbkz bbkz mentioned this issue Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants