-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
works good on ac200max, but please implement more #8
Comments
Hi, If it is possible I have the same request for adding the rest of the values which are provided by the python script. |
I have improved several things. Now I have 20+ values available in iobroker (via mqtt) including the ac/dc states of my AC200M. |
Will they also been shown on the EP500P ? |
When the address range of the EP500P is the same as for the already supported devices it should work. Otherwise we need to reverse engineer on a EP500P. |
I would appreciate a PR. |
@mariolukas: PR is done, please check. Since this is my very first contribution, I will also have to learn how Git/Github works in detail. |
Yes, thank you for your commitment. I appreciate it a lot. But it will take me some time to merge this into actual code.
One suggestion for your next PR. Just do your changes on the current code in the code folder and do a PR. That makes merging a lot easier for me. I need to compare each single file of your PR #33 in the main folder with the current code base in my source folder and cherry pick the changes you've made. |
Yes, no diffs are displayed. I noticed it and I try to do it the way it should be done next time. |
@mariolukas: Would it be better to close the pull request, updating my repository to the current status/code and committing my changes to it? Then I could make specific PRs with differences being displayed. But that would take a few days more... |
Yes i think that would be a better way to merge the PR. Please leave a comment to the PR and describe what you changed ( no details needed, only what you fixed or which new features are added ...). Thanks! |
Hello, how did you manage the connection to the Bluetti. I cannot connect to the AC200MAX. Did you have to make any changes to the code? thanks |
it works very well with ac200max, thanks for the great work!
but unfortunately not much is supported yet, maybe you could add the rest of https://github.com/warhammerkid/bluetti_mqtt/blob/main/bluetti_mqtt/core/devices/ac200m.py ?
thanks a lot
The text was updated successfully, but these errors were encountered: