Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream improvement in svg_to_path.py #229

Open
NGExplorer opened this issue Oct 24, 2024 · 1 comment
Open

Upstream improvement in svg_to_path.py #229

NGExplorer opened this issue Oct 24, 2024 · 1 comment

Comments

@NGExplorer
Copy link

There are some improvements in svg_to_paths.py which we want to upstream.

  1. ellipse2pathd
    Use 'cubic' curve to draw ellipse/circle. 'arc' is not supported on all platforms.

  2. polyline2pathd

    • Handle case of redundant 'z' command in polyline
    • Handle case when ellipse, polyline, rect does not have all attributes.
    • Add spaces between draw commands and its parameters
@NGExplorer
Copy link
Author

Hello @mathandy ,
There is some improvement we've done in svg_to_paths.py and want to upstream our changes.
Is there some specific test-suite/procedure we need to follow before creating a pull request ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant