Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speech demos issues #42

Open
pkra opened this issue Sep 23, 2021 · 1 comment
Open

speech demos issues #42

pkra opened this issue Sep 23, 2021 · 1 comment

Comments

@pkra
Copy link

pkra commented Sep 23, 2021

As discussed with @zorkow.

Besides #41 there are other issues with the demos

  • container is stripped by default - but the container has the aria-label
  • the container lacks a suitable role - custom elements have role=generic which does not allow for aria-label. With a flat label approach of these demos, I tend to go with img for simplicity's sake.

I also had issues with xml validation but I don't recall if that was a problem with the demo or with the jsdom/litedom adaptors.

@zorkow
Copy link
Member

zorkow commented May 20, 2022

#49 should fix these things. Even for deep speech you get aria-label and role attributes. If one were to add a tabindex=0 one could even do some rudimentary exploration, similar to hichart diagrams.

But just as a warning: These demos should show how to play with speech, not taken as fully developed a11y solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants