Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of messages with withheld keys #3678

Closed
richvdh opened this issue Jul 10, 2024 · 1 comment
Closed

Better handling of messages with withheld keys #3678

richvdh opened this issue Jul 10, 2024 · 1 comment

Comments

@richvdh
Copy link
Member

richvdh commented Jul 10, 2024

If we get a message that we can't decrypt, we check if we have previously received an m.room_key.withheld message about that session, and if so, show a different error message.

Two problems:

  • (untested) AFAICT, if the m.room_key.withheld arrives after the room message, we don't go back and update the error message.
  • There is a separate Posthog error code (RoomKeysWithheldForUnverifiedDevice) for events with a withheld code of m.unverified, allowing us to distinguish these "expected UTDs" from other UTDs. We don't use it currently.
@richvdh
Copy link
Member Author

richvdh commented Oct 17, 2024

Closing in favour of element-hq/element-meta#2588 and element-hq/element-meta#2589

@richvdh richvdh closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant