Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: prevent CRD deletion if their CRs still exist in cluster #329

Open
1 task done
loveRhythm1990 opened this issue Apr 18, 2023 · 1 comment
Open
1 task done
Assignees
Labels
kind/enhancement New feature or request

Comments

@loveRhythm1990
Copy link
Contributor

Is there an existing issue for enhancement?

  • I have checked the existing issues.

What would you like to be added ?

If a CRD has been deleted, all its CRs will be deleted too, in most case this is not a problem, since CRD will not be deleted generally, but we should consider this problem when our CRD should updated, like change a CRD field

Why is this needed ?

No response

Additional information

No response

@loveRhythm1990 loveRhythm1990 added the kind/enhancement New feature or request label Apr 18, 2023
@loveRhythm1990 loveRhythm1990 self-assigned this Apr 18, 2023
@loveRhythm1990
Copy link
Contributor Author

currently helm crds directory is under templates directory, most likely crds will be viewed as common resources, so when we uninstall matrixone-operator by helm uninstall, these crds will be uninstalled. By helm doc, we know that, directory crds should be in same directory with templates, but there are advantages and disadvantages about helm implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant