Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Zonemap Eval Optimization EvaluateFilterByZoneMap is too slow #10273

Open
1 task done
fengttt opened this issue Jun 27, 2023 · 7 comments
Open
1 task done
Assignees
Labels
kind/tech-request New feature or request priority/p0.5 source/dev issues from devs
Milestone

Comments

@fengttt
Copy link
Contributor

fengttt commented Jun 27, 2023

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Environment

- Version or commit-id (e.g. v0.1.0 or 8b23a93):
- Hardware parameters:
- OS type:
- Others:

Actual Behavior

Zonemap eval overhead is huge. See profiling

It is not clear to me what we should do. There need to be a design, but we must fix ths.

Expected Behavior

No response

Steps to Reproduce

No response

Additional information

No response

@fengttt fengttt added kind/tech-request New feature or request priority/p0 Critical feature that should be implemented in this version needs-triage labels Jun 27, 2023
@fengttt fengttt added this to the 1.0.0 milestone Jun 27, 2023
@fengttt
Copy link
Contributor Author

fengttt commented Jun 27, 2023

Changed into a feature, because need to work out design.

@fengttt fengttt changed the title [Bug]: Zonemap Eval Optimization EvaluateFilterByZoneMap is too slow [Feature]: Zonemap Eval Optimization EvaluateFilterByZoneMap is too slow Jun 27, 2023
@nnsgmsone
Copy link
Contributor

目前的zonemap eval无法和普通的expr一样转成一个pipeline expr,然后复用这个pipeline expr eval,需要想办法做到和普通的expr一样。

@aunjgr
Copy link
Contributor

aunjgr commented Jun 28, 2023

@nnsgmsone Why to handle zonemap evaluation using pipeline expr logic? What's the problem of previous approach?

@domingozhang
Copy link
Contributor

@fengttt please confirm who can be the owner and caculate plan dates.

@domingozhang domingozhang added the attention/being-discussed features being discussed label Jul 10, 2023
@nnsgmsone nnsgmsone removed the attention/being-discussed features being discussed label Jul 12, 2023
@nnsgmsone
Copy link
Contributor

@nnsgmsone Why to handle zonemap evaluation using pipeline expr logic? What's the problem of previous approach?

以前的逻辑不能处理函数。 @aunjgr ,比如最简单的cast函数

@XuPeng-SH XuPeng-SH modified the milestones: 1.0.0, Backlog Aug 13, 2023
@sukki37 sukki37 modified the milestones: Backlog, 1.1.0 Aug 23, 2023
@sukki37 sukki37 added the source/dev issues from devs label Aug 27, 2023
@fengttt fengttt assigned aunjgr and unassigned fengttt Aug 31, 2023
@fengttt
Copy link
Contributor Author

fengttt commented Aug 31, 2023

@aunjgr I think @XuPeng-SH may did some fast path work with zonemap. Please sync with him and let me know if we should close this one.

@domingozhang domingozhang added priority/p0.5 and removed priority/p0 Critical feature that should be implemented in this version labels Sep 7, 2023
@aunjgr aunjgr modified the milestones: 1.1.0, Backlog Nov 8, 2023
@aunjgr
Copy link
Contributor

aunjgr commented Nov 6, 2024

Zonemap evaluation is largely improved. This can be closed.

@aunjgr aunjgr assigned fengttt and unassigned aunjgr Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech-request New feature or request priority/p0.5 source/dev issues from devs
Projects
None yet
Development

No branches or pull requests

9 participants