Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask]: Merge redundant join operators #10684

Closed
aunjgr opened this issue Jul 15, 2023 · 0 comments
Closed

[Subtask]: Merge redundant join operators #10684

aunjgr opened this issue Jul 15, 2023 · 0 comments
Assignees
@aunjgr
Labels
kind/refactor Code refactor kind/subtask priority/p1 Medium priority feature that should be implemented in this version
Milestone
2.1.0

Comments

@aunjgr
Copy link
Contributor

aunjgr commented Jul 15, 2023

Parent Issue

#10526

Detail of Subtask

There are 15 differenct join operators in our codebase. Too much code duplication. If we will add other join implementations such as group join and sort-merge join, the number will increase by another 10.

Current join operators should be merge into only 2: hash join and nested-loop join.

Describe implementation you've considered

No response

Additional information

No response
@aunjgr aunjgr self-assigned this Jul 15, 2023
@aunjgr aunjgr added the priority/p1 Medium priority feature that should be implemented in this version label Jul 17, 2023
@sukki37 sukki37 added this to the 1.1.0 milestone Aug 27, 2023
@sukki37 sukki37 added the kind/refactor Code refactor label Aug 27, 2023
@domingozhang domingozhang added priority/p0 Critical feature that should be implemented in this version and removed priority/p1 Medium priority feature that should be implemented in this version labels Aug 28, 2023
@aunjgr aunjgr added priority/p1 Medium priority feature that should be implemented in this version and removed priority/p0 Critical feature that should be implemented in this version labels Sep 7, 2023
@aunjgr aunjgr modified the milestones: 1.1.0, 1.2.0 Nov 8, 2023
@sukki37 sukki37 modified the milestones: 1.2.0, 1.3.0-Backlog Apr 29, 2024
@sukki37 sukki37 modified the milestones: 1.3.0-Backlog, 1.3.0 Jul 8, 2024
@sukki37 sukki37 modified the milestones: 2.0.0, 2.1.0 Oct 14, 2024
@aunjgr aunjgr closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aunjgr aunjgr

Labels
kind/refactor Code refactor kind/subtask priority/p1 Medium priority feature that should be implemented in this version
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@aunjgr @sukki37 @domingozhang