Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring]: ColumnExpressonExecutor.Eval XXX must be fixed. #17749

Closed
fengttt opened this issue Jul 27, 2024 · 1 comment
Closed

[Refactoring]: ColumnExpressonExecutor.Eval XXX must be fixed. #17749

fengttt opened this issue Jul 27, 2024 · 1 comment
Assignees
@m-schen
Milestone
2.0.1

Comments

@fengttt
Copy link
Contributor

fengttt commented Jul 27, 2024

Why do you want to refactor this code?

The XXX comment in Eval clearly indicate this is a BUG.  It cannot be hacked around.

Describe the solution you'd like

Find the root cause and fix.

Describe alternatives you've considered

No response

Additional information

No response
@fengttt fengttt added this to the 1.3.0 milestone Jul 27, 2024
@m-schen m-schen mentioned this issue Aug 6, 2024
Merged
7 tasks
m-schen added a commit that referenced this issue Aug 6, 2024
@m-schen
support reset method for evaluate expression without opt. (#17902)
d00ead5 
## What type of PR is this?

- [ ] API-change
- [ ] BUG
- [x] Improvement
- [ ] Documentation
- [ ] Feature
- [ ] Test and CI
- [ ] Code Refactoring

## Which issue(s) this PR fixes:

issue #17749 

## What this PR does / why we need it:
支持expression的ResetForNextQuery()方法，
后续还有许多内容需要优化。
@m-schen m-schen mentioned this issue Aug 6, 2024
Merged
7 tasks
ouyuanning pushed a commit to ouyuanning/matrixone that referenced this issue Aug 14, 2024
@m-schen @ouyuanning
support reset method for evaluate expression without opt. (matrixor…
ad386e1 
…igin#17902)

- [ ] API-change
- [ ] BUG
- [x] Improvement
- [ ] Documentation
- [ ] Feature
- [ ] Test and CI
- [ ] Code Refactoring

issue matrixorigin#17749

支持expression的ResetForNextQuery()方法，
后续还有许多内容需要优化。
@m-schen m-schen mentioned this issue Oct 24, 2024
Merged
7 tasks
@m-schen
Copy link
Contributor

m-schen commented Oct 24, 2024

已经移除了由于join导致的出现RelPos > length(data)的情况。
但是存在RelPos < 0的情况，这块代码我不熟悉，修改难度很大，因此创建了以下issue待解决。

#19574

@sukki37 sukki37 modified the milestones: 2.0.0, 2.0.1 Nov 4, 2024
@fengttt fengttt closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-schen m-schen

Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
3 participants
@fengttt @m-schen @sukki37