Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message edits in the current channel count as unread messages #750

Open
evils opened this issue Dec 13, 2021 · 2 comments
Open

message edits in the current channel count as unread messages #750

evils opened this issue Dec 13, 2021 · 2 comments

Comments

@evils
Copy link

evils commented Dec 13, 2021

this results in a non-zero Unread count that doesn't go away when pressing M-a (switch to next unread channel)
currently this results in me doing a back-forth with M-s M-s to clear the unread count after finding M-a ineffective

as the current channel shows a message has been edited,
it seems best to only show Unread for messages whose (edited) status isn't visible in the current view (this assumes the user notices the (edited) indicator)
alternatively, actually switch to the current channel on M-a, as it is the one that is "unread" (this would hint to the user the unread message is actually in the current channel)

i also just experienced what i believe to be the "return to the starting point" feature of M-a switching to the starting point after an edit in the current channel, resulting in the Unread count going to 0 and landing me in a channel with no new message
(though a message appeared soon after, maybe the displaying of that messaged lagged the Unread count)
(i saw Unread: 0, saw an edit arrive, saw Unread: 1, pressed M-a, got switched to my previous channel, saw no new message, saw Unread: 0, saw a new message arrive)

this is on previous release, matterhorn 50200.14.1 on nixos-unstable
i didn't see anything in the changelog for the later release indicating the behaviour around this changed
(in case it's relevant: i also have mattermost-desktop open on the same device)

@jtdaugherty
Copy link
Member

Thanks for the report! We'll investigate.

@jasom
Copy link
Contributor

jasom commented Apr 17, 2024

I am seeing similar behavior. I haven't confirmed it's related to edited messages but M-a does not clear unread but a double M-s does.

It started happening recently without a client (or as far as I know server) upgrade. I'm also on nixos, and it happens with both 50200.17.0 and 50200.19.0

CORRECTION. This happened about the same time as our server was updated to v9.5 (specifically MM Enterprise 9.5.3) from 8.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants