Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification version 4 with source channel name and type #805

Open
3v1n0 opened this issue Jul 19, 2023 · 3 comments
Open

Add notification version 4 with source channel name and type #805

3v1n0 opened this issue Jul 19, 2023 · 3 comments

Comments

@3v1n0
Copy link

3v1n0 commented Jul 19, 2023

I often receive messages from users but I've multiple channels opened with them and I'm not sure from where the message is coming from (private message or a specific channel?).

So it would be nice to provide the notification source information too.

@jtdaugherty jtdaugherty changed the title Notification script: Provide information where the mention happened Add notification version 4 with source channel name and type Jul 19, 2023
@jtdaugherty
Copy link
Member

Thanks! I've updated the title to make the solution clear for when we can get around to implementing it.

@3v1n0
Copy link
Author

3v1n0 commented Jul 20, 2023

Do we need to add a new version?

Can't we just extend the current object? In any case I'd suggest you to start versioning the object itself so that one can just rely on that at script level.

@jtdaugherty
Copy link
Member

Starting with version 2, the object data does indeed already contain a version; see this. As for whether to add a new version, yes, that's my plan. Extending the current object without adding a new version changes what version "3" means, and that defeats the purpose of versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants