Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ai.moda's RFC3161 load balancer. #2523

Closed
wants to merge 1 commit into from

Conversation

Manouchehri
Copy link

@Manouchehri Manouchehri commented Jan 27, 2023

Resolves #1229.

Disclosure: I made this load balancer. I'm a fan of timestamping.

Release Note

Use ai.moda's RFC3161 load balancer to improve build times.

@mm-cloud-bot
Copy link

@Manouchehri: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @Manouchehri,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@Manouchehri
Copy link
Author

/check-cla

@Manouchehri
Copy link
Author

Manouchehri commented Jan 27, 2023

Release Note

Use ai.moda's RFC3161 load balancer to improve build times.

@tboulis
Copy link
Contributor

tboulis commented Jan 30, 2023

@Manouchehri Thank you for your contribution.
Unfortunately we cannot use this endpoint for security reasons.

@tboulis tboulis closed this Jan 30, 2023
@Manouchehri Manouchehri deleted the patch-1 branch January 30, 2023 13:02
@Manouchehri
Copy link
Author

Erm, what security reasons...?

@tboulis
Copy link
Contributor

tboulis commented Jan 30, 2023

Our Security team rejected this for two reasons.

  • This is an unknown server.
  • We have zero information about the company that provides this server. Their website is not accessible (under construction) and there is no other information that we could collect.
    9D9BDE86-E36E-4853-BCCE-18F9C4E8FFA3

I think those two are significant reasons not to proceed with this solution.
Thank you for your understanding

@Manouchehri
Copy link
Author

Ah, if your security team doesn't understand how TSAs and/or CAs work in general, then I can why they would mistakenly think either of those things matter.

You're currently accessing your TSA over HTTP... so if your security team believes they need to personally "trust" the TSA endpoint (instead of trusting the certificates it signs with), they've already screwed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a non rate limited timestamp server to accelerate Windows builds
4 participants