Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PersistenceMechanism: who should close it? #77

Open
mauricioaniche opened this issue Sep 29, 2017 · 1 comment
Open

PersistenceMechanism: who should close it? #77

mauricioaniche opened this issue Sep 29, 2017 · 1 comment

Comments

@mauricioaniche
Copy link
Owner

mauricioaniche commented Sep 29, 2017

Currently, the PersistenceMechanism is closed by repodriller, at the end of its execution.

@davisjam argues (and I agree) that it's a bit odd that the client opens it, but we close it. Read comments on #72 for more details.

We should only pay attention to not break the existing behavior as this would require people to upgrade all their existing studies.

@mauricioaniche mauricioaniche mentioned this issue Sep 29, 2017
@davisjam
Copy link
Contributor

Agreed that this needs to be backwards-compatible.

I think the default behavior should be to close them, as this is probably what the user wants and certainly what the current behavior is.

I think it would be fine to have a way to mark some PersistenceMechanism's as "user managed" in terms of who should close them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants