Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush in the CSVWriter? #92

Open
mauricioaniche opened this issue Oct 14, 2017 · 2 comments
Open

Flush in the CSVWriter? #92

mauricioaniche opened this issue Oct 14, 2017 · 2 comments

Comments

@mauricioaniche
Copy link
Owner

Do we still need it? It indeed has performance issues. See PR #90.
@davisjam
Copy link
Contributor

Actually see PR #91

@davisjam
Copy link
Contributor

To address this issue we need to evaluate the failure path to make sure close() is called on all PersistenceMethods. If so then we can safely remove this flush.

@davisjam davisjam mentioned this issue Oct 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mauricioaniche @davisjam