Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OAuth +Including CS fixes. #218

Closed
wants to merge 2 commits into from
Closed

Conversation

benlumley
Copy link

No description provided.

wise-gorilla and others added 2 commits May 13, 2020 21:34
This edit fix the oAuth issue that raised when changed the POST to use  json_encode instead of http_build_query mautic#216
@RCheesley
Copy link
Member

Thanks for submitting the PR - moved the issue over to the API repo!

@mautibot
Copy link

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/oauth2-issue-mautic-api/15783/2

@dennisameling dennisameling reopened this Oct 10, 2020
@dennisameling dennisameling changed the base branch from 3.0 to master October 10, 2020 15:12
@dennisameling
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Oct 10, 2020

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact @RCheesley. CLA has not been signed by @benlumley.

@cla-bot
Copy link

cla-bot bot commented Oct 10, 2020

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@dennisameling
Copy link
Member

Thanks a lot @benlumley for providing this PR and apologies for the incredibly late reply. We've just merged #217 which fixes the same issue. We'll of course credit both of you for fixing this issue 🚀 We expect to release an updated version of the API library very soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Api Library POST dont work after the change to use json_encode instead of http_build_query
5 participants