Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAVSDK structs and classes should conform protocol (Codable, Hashable, Identifiable) #199

Open
rligocki opened this issue May 24, 2021 · 3 comments

Comments

@rligocki
Copy link

During development of iOS app to control PX4 vehicles I found, that there are too many structs and classes that does not conform to protocols like Codable, Hashable, Identifiable. All these protocol must be added explicitly in app code. This solution looks awful. What do you think?

@JonasVautherin
Copy link
Collaborator

All the structs and classes are auto-generated, so it's "just" a matter of changing the templates. If you could give examples of some structs/classes as they are now, and how they should be modified, I can help with the templates 👍.

I am just not a Swift developer, so I need help on that side 😊

@rligocki
Copy link
Author

I tried to add Codable protocol to all enums, structs and classes. Problem is that even when I added Codable protocol to templates, there are still some data structures, that are not generated with Codable protocol. One of the problematic class is Mavsdk_Rpc_Core_CoreServiceClient. Where is a template for generation of this class?

@JonasVautherin
Copy link
Collaborator

Is it not generated by gRPC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants