Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMA SPI needs more attention to the multi-SPI-instance case #312

Open
multiplemonomials opened this issue Jul 22, 2024 · 0 comments
Open
Labels
Usability This makes Mbed harder to use, and needs to be cleaned up.

Comments

@multiplemonomials
Copy link
Collaborator

multiplemonomials commented Jul 22, 2024

Doing a quick look at the DMA SPI code, it seems to have some issues with the case where multiple SPI instances, pointing to different chip selects but the same peripheral and mosi/miso/sclk pins, are used at the same time. For instance:

  • What happens if you call abort() and the current transaction is being done by a different SPI instance on this bus? Behavior is not documented.
  • Calling abort_all() will abort transactions enqueued by other SPI instances on this bus, which is probably not desired.
  • There are a number of DMA related class variables in SPI which might be better in the per-peripheral structure instead of the class.
@multiplemonomials multiplemonomials added the Usability This makes Mbed harder to use, and needs to be cleaned up. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Usability This makes Mbed harder to use, and needs to be cleaned up.
Projects
None yet
Development

No branches or pull requests

1 participant