-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress output when requested #27
Comments
I think, keeping the same compression format as input is a good default behavior for the user, but add option to choose another one is important too. |
Hello @mbhall88, thanks for developing and maintaining rasusa. Sorry for stepping in, I am not sure whether this is the right thread or my issue is related to what is being discussed here. This is the code I am using:
Thanks in advance! |
Hey @Audald, yes this is the exact problem this issue describes. I don't know how I removed this functionality. I will get a fix out ASAP sorry. |
Thanks for your prompt answer, @mbhall88. I can bypass the issue by adding a |
This should now be fixed in version 0.5.0. I've also added some new compression CLI options |
Hey @natir.
Yes, I only just switched the parsing to needletail. Given I only just switched the parser I probably won't get around to switching it again anytime soon. Also, compile time isn't a major concern for me, especially since I distribute pre-compiled binaries and a bunch of other methods that mean users don't need to compile the project. I'm happy to review a PR with updated benchmark though.
Regarding niffler, you've made me realise somewhere along the line I have lost the compressed output functionality of this tool... Originally rasusa would infer the desired output compression from the path. I'll have to fix that.
Originally posted by @mbhall88 in #25 (comment)
It might also be a good idea to add a flag to allow the user to set the compression level also.
The text was updated successfully, but these errors were encountered: