Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More buttons :) #33

Open
haarp opened this issue Nov 11, 2020 · 2 comments
Open

More buttons :) #33

haarp opened this issue Nov 11, 2020 · 2 comments

Comments

@haarp
Copy link

haarp commented Nov 11, 2020

Hello,

I just made this work and it's working surprisingly well so far. Thanks for making this!

There are a couple of buttons I would like to request, which are useful:

  • Info (which briefly shows OSD with progress, timers, etc.)
  • Next/Previous chapter
  • Next/Previous playlist item
  • A-V delay +/- (next to audio track button?)
  • Sub delay +/- (next to sub track button?)
  • video-zoom maybe?

Thanks a lot!

PS: Maybe it's even a good idea to directly proxy mpv's ipc json format (with auth, and blacklist (for e.g. run command) added on top of course), instead of translating all commands on software? This way the Android software just needs to send the correct JSON, with no modifications to the server needed to add new commands.

@mcastorina
Copy link
Owner

Hey, glad you like it :)

Thanks for the suggestions, I always appreciate feedback! Can you elaborate more on video-zoom? Is that a feature of mpv?


Maybe it's even a good idea to directly proxy mpv's ipc json format (with auth, and blacklist (for e.g. run command) added on top of course), instead of translating all commands on software? This way the Android software just needs to send the correct JSON, with no modifications to the server needed to add new commands.

I originally avoided this for the security concerns associated with executing commands received from the network. Of course the server should only run on a local network where every device is trusted, presumably.

Python development is also faster than Android development (at least for me), so it was simpler to have the app send a single command that I can interpret however I want in the server.

I'll have to think more about it, but a proxy with a whitelist might be good. Feel free to contribute too :)

@haarp
Copy link
Author

haarp commented Nov 12, 2020

Can you elaborate more on video-zoom? Is that a feature of mpv?

Yup. I have this in my input.conf:

Ctrl+=		add video-zoom 0.1
Ctrl+-		add video-zoom -0.1

Very useful when your content has hardcoded black bars for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants