Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include unconvert as a library #52

Open
zaynetro opened this issue Mar 3, 2021 · 1 comment
Open

Include unconvert as a library #52

zaynetro opened this issue Mar 3, 2021 · 1 comment

Comments

@zaynetro
Copy link

zaynetro commented Mar 3, 2021 •
edited
Loading

Is there an interest on splitting unconvert into library and cmd? This will allow other projects like golangci-lint to use this project directly instead of depending on an old fork

I am ready to implement the changes myself. (Original discussion golangci/golangci-lint#1809 )
@zaynetro zaynetro mentioned this issue Mar 3, 2021
Closed
@dmitshur
Copy link
Collaborator

FWIW maligned was refactored to implement an analysis.Analyzer in mdempsky/maligned@c37866e so there's precedent, but I'd wait to hear from the package author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zaynetro @dmitshur