Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extract starting topo #85

Open
mdtanker opened this issue Aug 3, 2024 · 0 comments
Open

Refactor extract starting topo #85

mdtanker opened this issue Aug 3, 2024 · 0 comments

Comments

@mdtanker
Copy link
Owner

mdtanker commented Aug 3, 2024

In run_inversion, prior to iterations starting, the function extract_prism_data takes in the supplied starting prisms_layer extracts the prism spacing, calculated the starting topography, and adds it as variable starting_topo and topo.

The way extract_prism_data calculates the starting topography is:

topo_grid = xr.where(prisms_ds.density > 0, prisms_ds.top, prisms_ds.bottom)

This seems like an unnecessary step which could have unintended issues. We should just make it a requirement for the user to add a starting_topo variable to the prisms_layer when it's supplied to the inversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant