Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test run failures should not cause subsequent tests to time out. #39

Open
coreyti opened this issue Feb 11, 2022 · 1 comment
Open

Test run failures should not cause subsequent tests to time out. #39

coreyti opened this issue Feb 11, 2022 · 1 comment

Comments

@coreyti
Copy link
Member

coreyti commented Feb 11, 2022

example:

test/playwright_test.exs:7
** (FunctionClauseError) no function clause matching in Playwright.Browser.new_page/2

The following arguments were given to Playwright.Browser.new_page/2:
    # 1
    {:error, %Playwright.Channel.Error{message: "Timeout 30000ms exceeded."}}
    # 2
    %{}
  
Attempted function clauses (showing 1 out of 1):
  def new_page(%Playwright.Browser{session: session} = browser, options)

stacktrace:
  (playwright 0.1.17-preview-6) lib/playwright/browser.ex:153: Playwright.Browser.new_page/2
  test/playwright_test.exs:3: Playwright.PlaywrightTest.__ex_unit_setup_0/1
  test/playwright_test.exs:1: Playwright.PlaywrightTest.__ex_unit__/2
@ry4n1m3
Copy link
Contributor

ry4n1m3 commented Jun 25, 2024

👍🏻 We see this when we look for an element that doesn't exist within the timeout, the subsequent tests that re-use the browser don't recover. We'd like to see these timeouts returned as error tuples that don't crash the browser ideally

cc @mattwynne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants