Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a Merge Function trait #45

Open
Kerollmops opened this issue Oct 18, 2023 · 0 comments
Open

Introduce a Merge Function trait #45

Kerollmops opened this issue Oct 18, 2023 · 0 comments
Labels
breaking Everything that necessitate a bump of the major version number.

Comments

@Kerollmops
Copy link
Member

Currently, the merge function is anonymous. It is not very practical when you are refactoring code. I mean, typing thing is much better and makes the work easier. The code would also be less ugly.

grenad/src/merger.rs

Lines 106 to 110 in 3e684da

impl<R, MF, U> Merger<R, MF>
where
R: io::Read + io::Seek,
MF: for<'a> Fn(&[u8], &[Cow<'a, [u8]>]) -> Result<Cow<'a, [u8]>, U>,
{

@Kerollmops Kerollmops added the breaking Everything that necessitate a bump of the major version number. label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Everything that necessitate a bump of the major version number.
Projects
None yet
Development

No branches or pull requests

1 participant