Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tortoise cannot understand a sidecar injected via mutating webhook #190

Open
sanposhiho opened this issue Oct 15, 2023 · 1 comment · Fixed by #191
Open

Tortoise cannot understand a sidecar injected via mutating webhook #190

sanposhiho opened this issue Oct 15, 2023 · 1 comment · Fixed by #191
Labels
kind/bug Something isn't working kind/feature New feature or request

Comments

@sanposhiho
Copy link
Collaborator

The sidecar container is injected when the Pod is created.
But, the tortoise controller looks at the deployment spec to understand which container they have.

So, even if the Pods have the sidecar container in the end, the tortoise controller cannot notice them.

/kind feature

@sanposhiho sanposhiho added kind/bug Something isn't working kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 15, 2023
@sanposhiho
Copy link
Collaborator Author

sanposhiho commented Oct 16, 2023

Had a temporal patch for this. It should be working if the injected container is istio one.

But, other injected container cannot be handled.
#129 will fix this issue in general since we wouldn't look at deployment in the first place after that.

@sanposhiho sanposhiho reopened this Oct 16, 2023
@sanposhiho sanposhiho removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 27, 2023
@sanposhiho sanposhiho changed the title Tortoise cannot understand Injected sidecar Tortoise cannot understand a sidecar injected via mutating webhook Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant