Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container info in /cgroups on CentOS 6.5 #40

Closed
ssorallen opened this issue Jul 14, 2014 · 4 comments · Fixed by #41
Closed

Container info in /cgroups on CentOS 6.5 #40

ssorallen opened this issue Jul 14, 2014 · 4 comments · Fixed by #41
Labels

Comments

@ssorallen
Copy link

I have a question about deimos and centos 6.5 . I install mesos and docker but i have a problem with deimos . I check the source code and I found the problem (https://github.com/mesosphere/deimos/blob/master/deimos/docker.py#L109) I don’t know why in centos docker save the container information in /cgroups/. Any idea how to fix that ?

@ssalvatori
Copy link

I have the same problem, I tried changing the path in the deimos source but now I have a problem with memory attribute for the cgroups object

@ssalvatori
Copy link

I made a little change in deimos to work with centos 6.5 and kernel 3.15.*

[root@tmparq deimos]# uname -a
Linux tmparq.cloud.lan.com 3.15.3-1.el6.elrepo.x86_64 #1 SMP Tue Jul 1 12:42:44 EDT 2014 x86_64 x86_64 x86_64 GNU/Linux

diff --git a/deimos/docker.py b/deimos/docker.py
index b268624..90315c4 100644
--- a/deimos/docker.py
+++ b/deimos/docker.py
@@ -106,9 +106,9 @@ class Status(_Struct):

 def cgroups(cid):
     paths = []
-    paths += glob.glob("/sys/fs/cgroup/*/" + cid)
-    paths += glob.glob("/sys/fs/cgroup/*/docker/" + cid)
-    return dict((s.split("/")[4], s) for s in paths)
+    paths += glob.glob("/cgroup/*/" + cid)
+    paths += glob.glob("/cgroup/*/docker/" + cid)
+    return dict((s.split("/")[2], s) for s in paths)

@solidsnack
Copy link
Contributor

Maybe something like this would work everywhere?

diff --git a/deimos/docker.py b/deimos/docker.py
index b268624..7d5eef0 100644
--- a/deimos/docker.py
+++ b/deimos/docker.py
@@ -108,7 +108,10 @@ def cgroups(cid):
     paths = []
     paths += glob.glob("/sys/fs/cgroup/*/" + cid)
     paths += glob.glob("/sys/fs/cgroup/*/docker/" + cid)
-    return dict((s.split("/")[4], s) for s in paths)
+    paths += glob.glob("/cgroup/*/" + cid)
+    paths += glob.glob("/cgroup/*/docker/" + cid)
+    named_cgroups = [(s.split("/cgroup/")[1].split("/")[0], s) for s in paths]
+    return dict(named_cgroups)


 def matching_image_for_host(distro=None, release=None, *args, **kwargs):

@zircote
Copy link

zircote commented Jul 17, 2014

@solidsnack, thank you. That corrects the issue succinctly, will that be included in a near future version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants