Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More than just docker? #44

Open
hub-cap opened this issue Jul 24, 2014 · 3 comments
Open

More than just docker? #44

hub-cap opened this issue Jul 24, 2014 · 3 comments

Comments

@hub-cap
Copy link
Contributor

hub-cap commented Jul 24, 2014

Howdy,

Id like to use deimos to create OpenVZ containers. Would you be open to me hacking up deimos to work with more than one containerizer? Ive looked over the code a good bit and it seems like a good bit of the code is abstracted in a way that it wouldnt be hard to accomplish said task. Whaddya think?

Also i can attempt to bribe you with beer and tapas!

@tnachen
Copy link

tnachen commented Jul 24, 2014

Hi hub-cap, we definitely welcome PRs. Feel free to fork and open a PR when you have it done.

@hub-cap
Copy link
Contributor Author

hub-cap commented Jul 24, 2014

Right on. I just didnt want to do a bunch of work to find out yall wanted to keep this "docker centric". If thats not the case then its ON!

@solidsnack
Copy link
Contributor

At present, Deimos just hands all container infos to the Docker containerizer. A while back, I did a refactor, where all the proto parsing was handled by a router that looked at the image URLs (or looked up these URLs, based on the container ID) to pick a containerizer implementation.

Maybe a reasonable thing to do would be to store the image URL in the Deimos state? Then Deimos will know which sub-containerizer to use to route usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants