Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request "Forced BMH deletion" #1666

Open
matthewei opened this issue Apr 12, 2024 · 11 comments
Open

Feature Request "Forced BMH deletion" #1666

matthewei opened this issue Apr 12, 2024 · 11 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@matthewei
Copy link

What steps did you take and what happened:
[A clear and concise description on how to REPRODUCE the bug.]

matthew@ubuntu:~/github/metal3_dev/baremetal-operator|main⚡ ⇒  kubectl get bmh -A              
NAMESPACE   NAME                   STATE                        CONSUMER   ONLINE   ERROR   AGE
default     cmss-baremetalhost-1   powering off before delete              true             2m58s
matthew@ubuntu:~/github/metal3_dev/baremetal-operator|main⚡ ⇒  

What did you expect to happen:

Delete the BMH directly!

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Baremetal Operator version:
  • Environment (metal3-dev-env or other):

/kind bug

@metal3-io-bot metal3-io-bot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Apr 12, 2024
@agewagra
Copy link

Try to use patch and delete finalizers. BMH will be deleted

@dtantsur
Copy link
Member

Try to use patch and delete finalizers.

Please, PLEASE, never recommend anyone to delete finalizers, especially if they don't know 100% what they are doing. In this case, you can and probably will leave a dangling Node in Ironic.

@dtantsur
Copy link
Member

On the topic of the request: I think we miss a way to force-delete BareMetalHosts. The reason BMO works the way it works is to try leave the host in a safe state. E.g. a powered on worker can try to rejoin the cluster, messing up CAPI.

@Rozzii Rozzii changed the title How to delete BMH directly Feature Request "Forced BMH deletion" Apr 24, 2024
@Rozzii
Copy link
Member

Rozzii commented Apr 24, 2024

I have renamed this issue to represent an actionable feature request.
I agree with @dtantsur that we don't have forced BMH deletion and that could come handy for many users.
/triage accepted
/kind feature

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Apr 24, 2024
@Rozzii Rozzii removed the kind/bug Categorizes issue or PR as related to a bug. label Apr 24, 2024
@matthewei
Copy link
Author

I have renamed this issue to represent an actionable feature request. I agree with @dtantsur that we don't have forced BMH deletion and that could come handy for many users. /triage accepted /kind feature

yes, we need this feature

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2024
@Rozzii
Copy link
Member

Rozzii commented Jul 24, 2024

/remove-lifecycle stale.

@Rozzii
Copy link
Member

Rozzii commented Jul 24, 2024

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2024
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2024
@mquhuy
Copy link
Member

mquhuy commented Oct 23, 2024

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2024
@hardys
Copy link
Member

hardys commented Nov 29, 2024

I wonder if one way to achieve this is to fix #1729 so that it's possible to apply the detached annotation (which removes the node from Ironic), then delete the BMH (which should result in no finalizer related actions)?

It should already be possible to try this other than the race mentioned in #1729 so would be good to confirm if this is logically equivalent to the desired behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Status: Backlog
Development

No branches or pull requests

7 participants