Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement script for run_local_ironic #86

Open
dtantsur opened this issue Nov 25, 2024 · 2 comments
Open

Replacement script for run_local_ironic #86

dtantsur opened this issue Nov 25, 2024 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@dtantsur
Copy link
Member

BMO has a run_local_ironic script that is responsible for running Ironic in containers locally. The outcome of it does not strictly match what is deployed by deploy.sh or IrSO, and it's a tedious job to keep it up-to-date.

What if we create a new command in IrSO that uses the same code in pkg/ironic but creates local containers instead of using Kubernetes API? This way we would have only one place to maintain how we start Ironic.

/kind feature
/help

@metal3-io-bot
Copy link
Contributor

@dtantsur:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

BMO has a run_local_ironic script that is responsible for running Ironic in containers locally. The outcome of it does not strictly match what is deployed by deploy.sh or IrSO, and it's a tedious job to keep it up-to-date.

What if we create a new command in IrSO that uses the same code in pkg/ironic but creates local containers instead of using Kubernetes API? This way we would have only one place to maintain how we start Ironic.

/kind feature
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Nov 25, 2024
@Rozzii
Copy link
Member

Rozzii commented Dec 4, 2024

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants