Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a more recent version of black #1703

Open
cpelley opened this issue Apr 22, 2022 · 2 comments
Open

Using a more recent version of black #1703

cpelley opened this issue Apr 22, 2022 · 2 comments
Assignees

Comments

@cpelley
Copy link
Contributor

cpelley commented Apr 22, 2022

As discussed in #1702, we currently pin 'black' to 19.10b0 for both environment_a.yml and environment_b.yml. This gives rise to problems without pinning of its dependency 'click' (more information here: psf/black#2964).

For recent versions of black, this dependency issue with click has been resolved (>=22.3.0).
The question is then whether our pinning of black to 19.10b0 for environment_a.yml and environment_b.yml are strictly necessary?
Can we update this pinning to >=22.3.0
This does give rise to issues presented by black though I haven't looked at those changes in detail.

@cpelley cpelley self-assigned this Apr 22, 2022
@cpelley
Copy link
Contributor Author

cpelley commented Apr 22, 2022

@gavinevans @bayliffe is our pinning of black to 19.10b0 for environment_a.yml and environment_b.yml strictly necessary?

@bayliffe
Copy link
Contributor

@cpelley I don't think we pin for any reason other than leaving it floating means it can change underneath us. The github actions environment that is built can then differ from the local environment and we get test failures on PRs. Updating this would be fine by me, as long as the PR captured all of the changes required to conform to the newer version. It would also be worth ensuring it plays nicely with whatever version of isort we end up with as the two can ping-pong back and forth with particular combinations of versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants