Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set data-dependent height for bar chart #31

Open
erxclau opened this issue Aug 12, 2022 · 0 comments
Open

Set data-dependent height for bar chart #31

erxclau opened this issue Aug 12, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@erxclau
Copy link
Member

erxclau commented Aug 12, 2022

Currently, bar charts have a default height of 150. I think a better default would be to make height some multiple of the number of keys that the data has.

Say we want each bar to be 30 pixels in height. If we have 10 data entries (i.e. 10 bars), then the height of the bar chart should be set to 300 pixels (in reality the bars will be less than 30 pixels because of scaleBand padding but the idea stands).

If someone wants to set a specific height, then they'd still be able to do so with the height setter.

@erxclau erxclau added the enhancement New feature or request label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant