Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong padding of AdaptiveFeatureGenerator #11

Open
htzheng opened this issue Jul 19, 2020 · 2 comments
Open

wrong padding of AdaptiveFeatureGenerator #11

htzheng opened this issue Jul 19, 2020 · 2 comments

Comments

@htzheng
Copy link

htzheng commented Jul 19, 2020

Hi, I noticed that for AdaptiveFeatureGenerator, the encoder is implemented using padding of Conv,
self.layer1 = norm_layer(nn.Conv2d(opt.spade_ic, ndf, kw, stride=1, padding=pw))
However, the warping images have strong artifacts at boundry.
image

Instead, when replacing the padding with reflect padding, the result is significantly improved.
image

Because of this, it seems there is a difference between the pretrained model and the testing code. Also, when using reflect padding for training, I often find the training collapses with unknow error after several epochs. Did you notice the same issue?

@panzhang0212
Copy link
Contributor

Could you show the error log?

@htzheng
Copy link
Author

htzheng commented Aug 16, 2020

Hi, in the AdaptiveFeatureGenerator, I found feature backbone is extracted without reflect padding,
self.layer1 = norm_layer(nn.Conv2d(opt.spade_ic, ndf, kw, stride=1, padding=pw))
Because of this, the warped images have surrounding artifacts.
image

I wonder is there any ways to solve this artifact problem. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants