Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve version expression reason #1828

Closed
BernieWhite opened this issue May 24, 2024 · 0 comments · Fixed by #2683
Closed

Improve version expression reason #1828

BernieWhite opened this issue May 24, 2024 · 0 comments · Fixed by #2683
Assignees
@BernieWhite
Labels
bug Something isn't working feature: output Issues that affect output and results
Milestone
v3.0.0

Comments

@BernieWhite
Copy link
Member

BernieWhite commented May 24, 2024 •
edited
Loading

For the case:

field: properties.grafanaMajorVersion
version: '>=10'

The outputted reason is Path properties.grafanaMajorVersion: The version '9.-1.-1' does not match the constraint 'PSRule.Data.SemanticVersion+VersionConstraint'.

This could be improved by:

  • Handling the -1 when the value is just 9 instead of 9.0.0.
  • Fix the string formatting for the constraint.

Example case: Azure/PSRule.Rules.Azure#2883
@BernieWhite BernieWhite added bug Something isn't working feature: output Issues that affect output and results labels May 24, 2024
@BernieWhite BernieWhite self-assigned this Dec 21, 2024
@BernieWhite BernieWhite added this to the v3.0.0 milestone Dec 21, 2024
BernieWhite added a commit to BernieWhite/PSRule that referenced this issue Dec 21, 2024
@BernieWhite
Fixed string formatting of semantic version and constraints microsoft…
690d29f 
…#1828
@BernieWhite BernieWhite mentioned this issue Dec 21, 2024
Merged
7 tasks
BernieWhite added a commit that referenced this issue Dec 21, 2024
@BernieWhite
Fixed string formatting of semantic version and constraints #1828 (#2683
a32ad2f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
bug Something isn't working feature: output Issues that affect output and results
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Fixed string formatting of semantic version and constraints #1828 BernieWhite/PSRule
1 participant
@BernieWhite