Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install missing in chapter 04 and chapter 06 jupyter notebooks docs #592

Closed
bmerkle opened this issue Sep 14, 2024 · 3 comments
Closed

Comments

@bmerkle
Copy link
Contributor

bmerkle commented Sep 14, 2024

Is your feature request related to a problem? Please describe.
for chapter 04 and 06 the pip install tiktoken is missing.
Should we add this to the docs ?
We could also add a requirements.txt so that there is code for getting the packages and not only doc

It seems that tiktoken also requires rust compiler on the machine to build the libs, at least this was necessary in my case.

Describe the solution you'd like
I could update the docs accordingly

@koreyspace

Copy link

👋 Thanks for contributing @bmerkle! We will review the issue and get back to you soon.

Copy link

This issue has not seen any action for a while! Closing for now, but it can be reopened at a later date.

@bmerkle
Copy link
Contributor Author

bmerkle commented Nov 27, 2024

I have a fix (generated requirements.txt) for chapter 04 and chapter 06.
@koreyspace can you please reopen this issue ? :-)

koreyspace added a commit that referenced this issue Nov 28, 2024
fix for #592: added requirements.txt for easy pip deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants