Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Work Graphs] Remove SYNC_FLAG from Barrier intrinsics #101

Closed
llvm-beanz opened this issue Sep 25, 2023 · 1 comment · Fixed by #62
Closed

[Work Graphs] Remove SYNC_FLAG from Barrier intrinsics #101

llvm-beanz opened this issue Sep 25, 2023 · 1 comment · Fixed by #62
Assignees
@pow2clk
Labels
language-spec Issue with completed spec
Milestone
Shader Model 6.8

Comments

@llvm-beanz
Copy link
Collaborator

Which document does this relate to?
#62
#77

Describe the issue you see with the spec
The sync_flags parameter has been removed from the barrier intrinsic, we need to update the DXIL and WG specs.

Additional context

https://microsoft.github.io/DirectX-Specs/d3d/WorkGraphs.html#barrier
@llvm-beanz llvm-beanz added the language-spec Issue with completed spec label Sep 25, 2023
@llvm-beanz llvm-beanz self-assigned this Sep 25, 2023
llvm-beanz added a commit to llvm-beanz/hlsl-specs that referenced this issue Sep 25, 2023
@llvm-beanz
Update barrier definition
92e02ea 
This updates the barrier definition with the new design.

Partial fix for microsoft#101.
@github-project-automation github-project-automation bot moved this to 🆕 New in HLSL Roadmap Sep 25, 2023
@llvm-beanz llvm-beanz moved this from 🆕 New to 👀 In review in HLSL Roadmap Sep 25, 2023
@tex3d tex3d mentioned this issue Sep 25, 2023
Closed
@pow2clk pow2clk added this to the Shader Model 6.8 milestone Nov 6, 2023
@llvm-beanz llvm-beanz moved this to In Review in HLSL Language Features Nov 8, 2023
@llvm-beanz llvm-beanz moved this from In Review to Under Consideration in HLSL Language Features Nov 8, 2023
@llvm-beanz llvm-beanz moved this from Under Consideration to In Review in HLSL Language Features Nov 8, 2023
@pow2clk
Copy link
Member

pow2clk commented Dec 11, 2023

Should be closed by #62

@pow2clk pow2clk assigned pow2clk and unassigned llvm-beanz Mar 11, 2024
@pow2clk pow2clk mentioned this issue Mar 26, 2024
Merged
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in HLSL Roadmap Mar 29, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in HLSL Language Features Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pow2clk pow2clk

Labels
language-spec Issue with completed spec
Projects
HLSL Language Features
Status: Done
HLSL Roadmap
Archived in project
Milestone
Shader Model 6.8
Development

Successfully merging a pull request may close this issue.

[SM68] Add proposal for Work Graphs llvm-beanz/hlsl-specs
2 participants
@llvm-beanz @pow2clk