Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executeBatch in SQLServerPreparedStatement doesn't log updated rows #2191

Open
unit7-0 opened this issue Aug 10, 2023 · 3 comments
Open

executeBatch in SQLServerPreparedStatement doesn't log updated rows #2191

unit7-0 opened this issue Aug 10, 2023 · 3 comments
Labels
Enhancement An enhancement to the driver. Lower priority than bugs.

Comments

@unit7-0
Copy link

unit7-0 commented Aug 10, 2023

Driver version

12.4.0

Problem description

There is incorrect logging in the method SQLServerPreparedStatement#executeBatch of the rows which were affected. Variable updateCounts is of array type and method Logger#exiting is used, which accepts Object as the last parameter and it then is wrapped into array in exiting method itself, therefore in logs it appears as array string representation: [I@1ce386b2.

Example output

Aug 10, 2023 2:29:17 PM com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement:15 executeBatch
FINER: RETURN [I@1ce386b2
@Jeffery-Wasty
Copy link
Contributor

Hi @unit7-0,

Thank you, we'll take a look into this and get back to you with our next steps.

@lilgreenbird
Copy link
Contributor

hi @unit7-0

this is in quite a few places and is just a 1 liner entering/exiting log. What would you expect to see in this case or are you suggesting to simply remove the object from the log line?

@lilgreenbird lilgreenbird added the Question Used when a question is asked, as opposed to an issue being raised label Aug 21, 2023
@lilgreenbird lilgreenbird added Enhancement An enhancement to the driver. Lower priority than bugs. and removed Question Used when a question is asked, as opposed to an issue being raised labels Aug 23, 2023
@lilgreenbird
Copy link
Contributor

as mentioned this is in quite a few places agree it's an annoyance I've marked this as an enhancement and included in our backlog. Please note this is low priority so will be bumped by other higher priority issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An enhancement to the driver. Lower priority than bugs.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants