Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rich Experiences] White Screen When Moving Query Results #18324

Open
tmonoceros opened this issue Oct 28, 2024 · 5 comments
Open

[Rich Experiences] White Screen When Moving Query Results #18324

tmonoceros opened this issue Oct 28, 2024 · 5 comments

Comments

@tmonoceros
Copy link

tmonoceros commented Oct 28, 2024

  • MSSQL Extension Version: 1.25.0
  • VSCode Version: 1.94.2
  • OS Version: Windows 10 10.0.19045 Build 19045

Steps to Reproduce:

  1. Enable "rich experiences" in settings.json "mssql.enableRichExperiences": true
  2. Execute any query

My results show up in the default "Query results" pane as expected (actual data removed from the screenshot)

Image

However, if I try to move the query results window to another pane, it goes completely white. Nothing I can do - not rerunning the query, not moving it back - seems to fix this.

Image

@caohai
Copy link
Member

caohai commented Oct 28, 2024

@tmonoceros Thanks for creating the issue!

move the query results window to another pane

Are you doing this via these options?

Here's what it looks like if I move the panel area to the right (tested on Mac and Windows)

@tmonoceros
Copy link
Author

tmonoceros commented Oct 29, 2024

I was clicking and dragging to move the window. Here's a .gif showing this in action. I'm not moving the whole panel; I'm specifically moving the query results tab.

Image

@caohai
Copy link
Member

caohai commented Oct 29, 2024

@tmonoceros Thanks for the GIF, I was not aware of this drag and drop feature of panel tabs. I can confirm the repro, will take a look.
Is the goal of this operation to have the QUERY RESULT pane on the right side while keeping the rest panel (Terminal/Output etc) at the bottom? Do you think this change we plan to make will improve your workflow? #18316 (comment)

@caohai caohai added this to the November 2024 Release milestone Oct 29, 2024
@tmonoceros
Copy link
Author

tmonoceros commented Oct 29, 2024

I don't have a strong opinion on the exact fix right now. The fact that you're allowed to pop the query results out, but doing so breaks them and forces you to disable and reenable rich experiences to fix it, is a pretty clear bug that can actually be pretty disruptive. But it might just be muscle memory that causes me to prefer popping the query results out - that's how it works without Rich Experiences enabled, so that's what I'm used to.

I wouldn't complain (yet, anyway) if the fix was to just prevent the query results from being popped out. But if there's no reason to disallow popping the query results out (I don't know enough about the difference between editor panels and the rest panel to have an opinion there), seems like a straightforward win to me. I will say that everyone who starts using rich experiences will see this change in behavior, and so other people might have a stronger preference to be able to pop the results out to another panel.

@caohai
Copy link
Member

caohai commented Oct 29, 2024

The fact that you're allowed to pop the query results out, but doing so breaks them and forces you to disable and reenable rich experiences to fix it, is a pretty clear bug

The ability to pop the QUERY RESULT tab out of the vscode panel area and move this single tab into a document window(by drag-and-drop) comes from VSCode itself and I was not aware of this during until now. We'll look into the bug and hopefully get it fixed by next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants