Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light title bar on Linux with dark gtk theme variant #181831

Open
TomiOhl opened this issue May 8, 2023 · 3 comments
Open

Light title bar on Linux with dark gtk theme variant #181831

TomiOhl opened this issue May 8, 2023 · 3 comments
Assignees
@deepak1556
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron linux Issues with VS Code on Linux upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-pending Issues that are caused by chromium but have not been reported due to pending minimal repro

Comments

@TomiOhl
Copy link

TomiOhl commented May 8, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.78.0
  • OS Version: elementary OS 7, latest

Occurs since:
April's update, a.k.a 1.78.0

Steps to Reproduce:

  1. Set GTK_THEME_VARIANT to dark
  2. Launch vs code
  3. The native title bar is light, while it did match the color of the menu below it previously (which still does respect the setting).

Screenshot:
image

Additional info:
See the comment here: hardpixel/dark-variant#5 (comment)
@roblourens roblourens assigned deepak1556 and unassigned roblourens May 9, 2023
@fkrull fkrull mentioned this issue Sep 20, 2023
Closed
@deepak1556
Copy link
Collaborator

/duplicate #130974

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 5, 2023
@TomiOhl
Copy link
Author

TomiOhl commented Dec 5, 2023 •
edited
Loading

@deepak1556 this isn't fixed in version 1.84.2 for me, title bar is still light despite the system (elementary OS 7.1 with all updates installed) being in dark mode.
Also it didn't occur at the time that other issue was posted, only since this april, so this seems very different.

@deepak1556 deepak1556 reopened this Dec 5, 2023
@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron upstream-issue-pending Issues that are caused by chromium but have not been reported due to pending minimal repro linux Issues with VS Code on Linux and removed *duplicate Issue identified as a duplicate of another issue(s) labels Dec 5, 2023
@TomiOhl
Copy link
Author

TomiOhl commented Feb 1, 2024

Change in 1.86: the toolbar and the context menus no longer respect the gtk theme anymore at all. They do follow the freedesktop dark style setting though, which is nice!
Sadly the title bar's color is still not affected and is always light.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepak1556 deepak1556

Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron linux Issues with VS Code on Linux upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-pending Issues that are caused by chromium but have not been reported due to pending minimal repro
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@roblourens @deepak1556 @TomiOhl @vscodenpa