Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine the fate of the proof key tests #22

Closed
tylerbutler opened this issue Jul 27, 2018 · 11 comments · May be fixed by #86
Closed

Determine the fate of the proof key tests #22

tylerbutler opened this issue Jul 27, 2018 · 11 comments · May be fixed by #86
Labels
feature needs discussion

Comments

@tylerbutler
Copy link
Member

tylerbutler commented Jul 27, 2018 •
edited
Loading

The proof key tests can’t work as-is because there’s no signing key. We can disable the tests, but I think a better fix would be to provide a dummy WOPI discovery XML file in this repo and expose a key there. It could be a fixed key since it’s only used for testing.
@raffis
Copy link

raffis commented May 17, 2019

Should be disabled for now, it is irritating that those tests fail even if implemented correctly.

@raffis raffis mentioned this issue May 17, 2019
Closed
@tylerbutler tylerbutler mentioned this issue Oct 2, 2019
Closed
@tylerbutler tylerbutler mentioned this issue Dec 12, 2019
Closed
@thomaslevesque
Copy link
Contributor

a better fix would be to provide a dummy WOPI discovery XML file in this repo and expose a key there. It could be a fixed key since it’s only used for testing.

👍

That's what I did in my working copy to be able to pass those tests. Most of the necessary code is already there, it just needs a key.

@thomaslevesque
Copy link
Contributor

I'd like to emphasize how important it is to be able to run these tests locally. We can't use the test WOPI environment to debug on the local machine, so being able to use wopi-validator-core is extremely helpful. There's very little work needed to make the proof key tests work; I can send a PR if you like.

@tylerbutler
Copy link
Member Author

PRs are welcome.

@thomaslevesque thomaslevesque mentioned this issue Dec 16, 2019
Open
@thomaslevesque
Copy link
Contributor

@tylerbutler did you see my PR (#86)? I didn't receive any feedback

@sergiypopovych7576
Copy link

@thomaslevesque @tylerbutler
Hi guys, is there any progress on this? I see we have a PR, but it was not reviewed

Also, maybe we can have a small update in Readme to describe how to run proof key tests?

@mikeebowen
Copy link

@tylerbutler @thomaslevesque , there hasn't been an update on this in quite a while. Are there plans to merge this? Working tests for the proof keys would be very helpful. Thanks!

@v-stefansi
Copy link
Collaborator

We are in the process of closing this GitHub repository. This issue has been moved to the CSPP team ADO backlog list for consideration. If you would like to follow up or provide more information, please reach out to [email protected].

@mikeebowen
Copy link

@v-stefansi

Where will this repository be hosted after it has been closed?

@v-stefansi
Copy link
Collaborator

v-stefansi commented Jan 30, 2023 via email

@mikeebowen
Copy link

@v-stefansi ,

The contacts in your post are blocked out. Can you please re-post.

Will this repo be hosted somewhere else publicly, e.g. Azure DevOps, GitLab, etc.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature needs discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dummy proof keys and discovery XML thomaslevesque/wopi-validator-core
6 participants
@tylerbutler @thomaslevesque @raffis @mikeebowen @sergiypopovych7576 @v-stefansi