Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeoplePicker control of Microsoft.Toolkit.Graph.Controls Asking for singing again if already & Sing out automatically after adding new event #42

Closed
3 tasks
vikanirav opened this issue Apr 23, 2022 · 3 comments
Labels
cannot repro Issue cannot be reproduced using the information provided

Comments

@vikanirav
Copy link

Where did you get the code?

Describe the bug
After sign in into the given demo application, I was trying to add new event. It is asking for sign in again when I try to search event Attendee by their name in PeoplePicker control.

To Reproduce
Steps to reproduce the behavior:
Issue 1:
1. Open the application from visual studio
2. sign in into the application & go to the NewEvent Page
3. Try to search by name in Attendee Textbox(PeoplePicker control) : Use name of already sign in user
4. After sign in again from sign in window, sign in window will not close. you need to close manually.
5. Create event & after creating it will sign out you from application
6. go to the Calendar page, it will ask for sign in again

Issue 2:
1. Open the application from visual studio
2. sign in into the application & go to the NewEvent Page
3. Try to search by name in Attendee Textbox(PeoplePicker control) : Use different name of user by which you are not sign in
4. After sign in again from sign in window, sign in window will hang.
5. go to the Calendar page, it will ask for sign in again

Expected behavior

  1. After sign in into the application, user try to search user by their name in Attendee Textbox(PeoplePicker control), I should not ask for sign in again.
  2. If user try to search by different user name, sign in window should not hang

Screenshots
After search user by different name than already sign in, the app just hangs indefinitely and a little blue flashing dot appears in the upper left hand corner. (See attached image for issue 2)
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: N/A
  • Version: N/A

Dependency versions

  • Authentication library (MSAL, etc.) version:
  • Graph library (Graph SDK, REST library, etc.) version:

Additional context
Visual studio 22

@ghost ghost added the needs triage 🔍 New issue, needs triage label Apr 23, 2022
@jasonjoh
Copy link
Member

It looks like there's a missing permission scope that the people picker needs: People.Read. If you add that scope to your OAuth.resw does it help?

I would also recommend investigating replacing the Microsoft.Toolkit.Graph.Controls (which is deprecated) with their recommendation: CommunityToolkit.Graph.Uwp. I'm planning to update this sample to use it when I can.

@jasonjoh jasonjoh added needs author feedback Waiting for author (creator) of issue to provide more info and removed needs triage 🔍 New issue, needs triage labels Apr 28, 2022
@vikanirav
Copy link
Author

Hello @jasonjoh,
Thank you for replying.

I added your suggested permission and people picker is working fine now. But I am getting inconsistence sign in behavior in the application. It is asking me for sign in again even though I already signed in into the application[See attached screenshot].

I also tried with "CommunityToolkit.Graph.Uwp" nuget packages. But I am getting singout state after sign in. Please check this issue. CommunityToolkit.Graph.Uwp issue

image

@ghost ghost added needs attention 👋 Waiting on Microsoft to provide feedback and removed needs author feedback Waiting for author (creator) of issue to provide more info labels Apr 29, 2022
@jasonjoh jasonjoh added cannot repro Issue cannot be reproduced using the information provided and removed needs attention 👋 Waiting on Microsoft to provide feedback labels Oct 5, 2022
@jasonjoh
Copy link
Member

jasonjoh commented Oct 5, 2022

Closing as we've updated to use the CommunityToolkit.Graph.Uwp packages, and I cannot reproduce the second issue mentioned.

@jasonjoh jasonjoh closed this as completed Oct 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cannot repro Issue cannot be reproduced using the information provided
Projects
None yet
Development

No branches or pull requests

2 participants