Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you please help me with proof keys implementation #7

Open
priyanshumaurya007 opened this issue Mar 9, 2024 · 2 comments
Open

Comments

@priyanshumaurya007
Copy link

I wanted to extend my sincere appreciation for the invaluable resource your repository has been during my WOPI work.

As I dive into implementing WOPI proof keys, I've noticed some commented-out sections in the code. Could you offer some guidance on how to proceed?

@mikeebowen
Copy link
Owner

Can you point to which section of the code you're referring?

@mikeebowen
Copy link
Owner

Hi @priyanshumaurya007, I realized you're referring to the proof keys. Unfortunately, it's commented out, because I haven't completed the implementation. Part of the difficulty is that the wopi-validator-core test for proof keys currently will always fail. There is a PR with a fix here (microsoft/wopi-validator-core#86), but it hasn't been touched in 4 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants