-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reconstitution] Improve synthesize output quality #1528
Comments
Yeah we can maybe align the y-coords between line elements (words) and add some small horizontal default padding between detections |
how to change the font_family ? @felixdittrich92 |
|
same warning even i pass the font_family.. @felixdittrich92
|
The font is installed on your system ? |
yes i have that font in my project folder.. @felixdittrich92 |
Ah ok got it that's not enough you need to install the font on your system : https://linuxiac.com/how-to-install-fonts-on-linux/#:~:text=Go%20to%20%E2%80%9CSystem%20Settings%E2%80%9D%20%3E,%E2%80%9CInstall%20from%20File%E2%80%9D%20button.&text=Then%20select%20the%20font%20files,%2Dwide%20or%20per%2Duser. |
see the below input and output results.. result image quality is very poor.. pixels were broken @felixdittrich92 |
@felixdittrich92 any update? |
Hi @tzktz 👋, Unfortunately i don't have the time to work on that at the moment, so we need to address this later on or you work on that if you want (feel free to open a PR) related code can be found at: doctr/doctr/utils/visualization.py Line 291 in 0d84915
Best regards, |
@felixdittrich92 Hey, sorry for being MIA. I needed to take some time off. I am back now and I was hoping I could take up this issue? Let me know regarding this :) |
Hey @SkaarFacee 👋 |
Okay thanks. Let me take a look on what I can do |
@felixdittrich92 Do you have any suggestions on how I can improve the quality of the image ? |
@SkaarFacee |
Okay, I will take a look and see what can be done over the weekend. This doesn't look that complex at quick glance :) |
Yeah i think too :) |
Hey, I am working on on this, sorry for the delay. Something came up at work and got me busy |
@felixT2K |
Correct that was what i have had in mind you know which boxes are in one line (of `resolve_lines=True otherwise if only one line element available keep the y coords of each box) then take the lines y coordinate for each box to straighten the boxes on the line :) |
@SkaarFacee any updates ? 🤗 |
Hey, I am soo sorry. I had some personal issues that needed some time to be resolved. Everything is fine now and back to normal. I shall give you an update asap now 😓 😞 |
No problem :) In the meanwhile i identified the root issue.
|
Regarding the font size computation, should we maybe add a limit to the font to page size ratio so that the issue becomes less frequent ? Also regarding the line geometry alignment, I think maybe we can also add an tolerance value of some sort so that words that have y pixel values as 40 and say 43 come together in a straight line. ( Here I assume the tolerance is of +-5) |
Hey @SkaarFacee 👋,
|
Yes, do we have some sample images so to get started with in this case ? |
Yes give me few minutes i can attach some |
Here you go :) |
Are these samples that need to be improved or a combination of good outputs and bad outputs ? |
Only some samples for testing :) |
see the result image..
Originally posted by @tzktz in #1525 (comment)
The text was updated successfully, but these errors were encountered: