Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] MixinSquared target resolution support #2333

Open
ByThePowerOfScience opened this issue Jul 18, 2024 · 1 comment
Open

Comments

@ByThePowerOfScience
Copy link

Minecraft Development for IntelliJ plugin version

2024.1-1.8.0

Description of the feature request

When someone puts bad logic in a Mixin, MixinSquared is an incredibly-helpful library for patching it. Unfortunately, since it uses another annotation (@TargetHandler) for its target bootstrapping, MCDev doesn't natively understand it and can't offer the awesome Mixin-targeting support you guys put in it.

It should be a simple addition; all that would need to be done is recognize the following format for target resolution:

@TargetHandler(
  mixin="path.to.TargetMixin",
  name="nameOfTargetMethod(LOptionalArgumentsIfAmbiguous)",
  prefix="optionalPrefix$" // optional; for full-method injections of soft-implemented interface methods, aka the `ident$getUUID()` thing in the Mixin wiki that people don't usually have to use
)
@Inject( // or @Redirect, etc
  method="@MixinSquared:Handler",
  // the rest is the same as normal
)

and resolve it to "Targeted method: path.to.TargetMixin#nameOfTargetMethod(arguments)".

Thank you for your time, and for considering this suggestion!

@Earthcomputer
Copy link
Member

The author of MixinSquared is already working on an intellij plugin for this, see Bawnorton/MixinSquared#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants