Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "instaclick/php-webdriver" in API Client implementation #120

Open
aik099 opened this issue Mar 13, 2024 · 0 comments
Open

Don't use "instaclick/php-webdriver" in API Client implementation #120

aik099 opened this issue Mar 13, 2024 · 0 comments

Comments

@aik099
Copy link
Member

aik099 commented Mar 13, 2024

Currently, the API Client classes are using the PHP classes (not WebDriver itself) of the instaclick/php-webdriver dependency, which will cause problems when we decide to switch to another default Mink session driver (not selenium2).

We need to create the abstract AbstractAPIClient class with cURL communication support and let actual clients (listed in examples) communicate through it.

Examples:

  • the BrowserStackAPIClient is using ServiceFactory::getInstance()->getService('service.curl') to make cURL requests
  • the SauceLabsAPIClient is using SauceRest class to communicate with SauceLabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant