Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Remote Code Coverage" code #13

Open
aik099 opened this issue Feb 6, 2014 · 3 comments
Open

Improve "Remote Code Coverage" code #13

aik099 opened this issue Feb 6, 2014 · 3 comments

Comments

@aik099
Copy link
Member

aik099 commented Feb 6, 2014

  1. find a reason why PHPUNIT and SELENIUM words are being used in prepend.php and append.php
  2. replace append.php with a function registered via register_shutdown_function (as in Codeception)
  3. convert append.php/prepend.php/phpunit_coverage.php into regular namespaced class, that can be tested
  4. here is nice example http://tech.vg.no/2014/01/21/generating-code-coverage-of-behat-tests/
@aik099
Copy link
Member Author

aik099 commented Feb 8, 2014

Also the new RemoteCoverage statement should be moved to DIC.

aik099 pushed a commit that referenced this issue Feb 23, 2014
@stof
Copy link
Member

stof commented Jan 8, 2015

@aik099 the files have been converted to a class using register_shutdown_function 11 months ago. Is there anything left or can it be closed ?

@aik099
Copy link
Member Author

aik099 commented Jan 8, 2015

That's what create 20% loss of code coverage. Code is written theoretically, but not 100% tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants